The secure CMS.

Welcome to Geeklog, Anonymous Friday, December 27 2024 @ 08:47 pm EST

Geeklog Forums

missing closing tags

 New Topic  Post Reply
 07/25/04 10:26pm (Read 1,520 times)  
Status: Banned

machinari

Forum User
Full Member
Registered: 03/22/04
Posts: 1512

  • under "user functions" click preferences.

  • under comment preferences block click view source

  • notice that there are no closing tags for the "select" input type
    on both the "display mode" and the "sort order" form entries.

this is not a big deal because the closing table cell fixes all. but when
you go and layout the form without tables, using only CSS-P, well, let's just say
that those tags need to be closed otherwise your form is doing a disappearing act.


i've closed them in the template file because i would, as much as possible, like to
stay away from the GL core when making my themes. But if anybody is releasing anymore
of the 1.3x line before GL2, then maybe throw this one in there. no biggy tho.


at approx. line 589 in usersettings.php (GL1.3.9sr1) change this:


Text Formatted Code

    $selection = '<select name="commentmode">';
    $selection .= COM_optionList ($_TABLES['commentmodes'], 'mode,name',
                                  $A['commentmode']);
    $preferences->set_var ('displaymode_selector', $selection);

    $selection = '<select name="commentorder">';
    $selection .= COM_optionList ($_TABLES['sortcodes'], 'code,name',
                                  $A['commentorder']);
    $preferences->set_var ('sortorder_selector', $selection);

 

to this:


Text Formatted Code

    $selection = '<select name="commentmode">';
    $selection .= COM_optionList ($_TABLES['commentmodes'], 'mode,name',
                                  $A['commentmode']);
    $selection .= '</select>'; //closing tag added
    $preferences->set_var ('displaymode_selector', $selection);

    $selection = '<select name="commentorder">';
    $selection .= COM_optionList ($_TABLES['sortcodes'], 'code,name',
                                  $A['commentorder']);
    $selection .= '</select>';  //closing tag added
    $preferences->set_var ('sortorder_selector', $selection);

 
 Quote
 07/26/04 12:00am  
Status: offline

vinny

Site Admin
Admin
Registered: 06/24/02
Posts: 352
Location:Colorado, USA
The best place for this is proobably as a patch submission to the geeklog project page at:

http://project.geeklog.net/tracker/?atid=107&group_id=6&func=browse

That way Dirk definitely won't miss it. Good timing by the way, as I think Dirk is starting to think about a 1.3.10 release...

-Vinny
 Quote
 07/26/04 04:10pm  
Status: Banned

machinari

Forum User
Full Member
Registered: 03/22/04
Posts: 1512

done, thanks

i've never made a patch before... Dirk would say, "you still haven't"

time for coffee
 Quote
 New Topic  Post Reply
All times are EST. The time is now 08:47 pm.
  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content