Welcome to Geeklog, Anonymous Sunday, December 22 2024 @ 02:48 pm EST

Geeklog Forums

Nested Comment been broken for ages now


Status: offline

ScurvyDawg

Forum User
Full Member
Registered: 11/06/02
Posts: 523
Go to any article, any article at all that has comments.

Then go to a nested view for those comments.

You will see that on all the default themes and I am sure most custom ones that the sub comments run off the right hand side of the page.

I have brought this up and been ignored in the past. I dont see why nobody has much to say about this.

What causes it??

Sorry just feeling like I have been

thanks
 Quote

Status: offline

vinny

Site Admin
Admin
Registered: 06/24/02
Posts: 352
Location:Colorado, USA
I see what you mean, I'll take a look at this this coming weekend (assuming I have time). I think its just a style issue.

-Vinny
 Quote

Status: offline

Dirk

Site Admin
Admin
Registered: 01/12/02
Posts: 13073
Location:Stuttgart, Germany
Quote by vinny: I see what you mean

I don't, actually

Anyone care to provide some screenshots?

bye, Dirk
 Quote

Status: offline

ScurvyDawg

Forum User
Full Member
Registered: 11/06/02
Posts: 523
I will do, when I get home this evening.

I will also see if it is only in IE that it is an issue as that is all I have at work. I use Firefox at home.

Thanks
 Quote

Status: offline

ScurvyDawg

Forum User
Full Member
Registered: 11/06/02
Posts: 523
Ok I took this screen shot and posted a link to it here a while ago but here it is again.

you will see the text just goes off into nowhere on the right.

GL Nested Error Image
 Quote

Status: Banned

machinari

Forum User
Full Member
Registered: 03/22/04
Posts: 1512
looked at your pic and that is most definitely a style issue.
you'll have to scour your template and css files looking for widths.

My bet is that you are using a css laid out design and the plugin is breaking it with a width of 100%.

a quick fix, if that's the prob, would be to shove the content column, or at least when it calls a plugin with 100% widths, into a table cell:
Text Formatted Code
<table cellspacing="0" cellpadding="0" border="0"><tr><td width="1%">

 

If you don't want the content to be in a cell all the time, but only when a plugin is called, this is what i did in my COM_siteHeader():
Text Formatted Code
    //quickfix for table-laden plugins not cooperating with CSS-P.
    //add your plugin dir to the $plugins array.
    $plugins = array(forum, faqman, staticpages, stats, ewiki, filemgmt, menu,);
    $clicked = $_SERVER['REQUEST_URI'];
    $plugin_fix = '';
    foreach ($plugins as $val) {
        if (eregi($val, $clicked)) {
            $plugin_fix = "<table cellspacing="0" cellpadding="0" border="0"><tr><td class="forumfix">";
        }
    }
    $header->set_var( 'plugin_fix', $plugin_fix );
    //end quickfix for table-laden plugins breaking this theme


 

You can put that in a custom COM_siteHeader().

If that's not the problem, sorry.

just noticed you said it was happening with article comments. hmmm... prolly have to scour the layout in your /layout/theme/comments dir.
 Quote

Status: offline

ScurvyDawg

Forum User
Full Member
Registered: 11/06/02
Posts: 523
I am actually a version or so behind and it does not happen on my site but I see it in all the default themes on geeklog.net so I thought I would bring it up again.

 Quote

Status: offline

shetzel

Forum User
Chatty
Registered: 03/19/04
Posts: 39
Yeah, I noticed this problem a while ago. My fix for it can be found back on this thread.

http://www.geeklog.net/forum/viewtopic.php?forum=3&showtopic=32216

I fixed it by encasing the comment in another table in the template, as mentioned above, and it does only occur in IE, as mentioned above. I imagine that vinny will get a patch in the next release.
 Quote

Status: offline

shetzel

Forum User
Chatty
Registered: 03/19/04
Posts: 39

Oh, and not to beat a dead horse, but it is definitively a problem with the IE rendering engine. It seems to me that it's a flaw in the way they handle tables, but since most people use IE (including most of my users), I can appreciate wanting to solve this.

A full report of my experiments can be found at the same link, here.

 Quote

Status: offline

ScurvyDawg

Forum User
Full Member
Registered: 11/06/02
Posts: 523
Happens in Firefox on my home box.

???

 Quote

Status: offline

shetzel

Forum User
Chatty
Registered: 03/19/04
Posts: 39
Odd. I figured the problem was only in IE. I'm surprised that the Firefox people would have made the same (poor) choice, IMHO. I don't think that this a bug in the browsers, per se, since it may not be specified how to handle indents like this. However, I struggle to think of a way that this behavior could be useful.
 Quote

All times are EST. The time is now 02:48 pm.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content