Welcome to Geeklog, Anonymous Saturday, December 21 2024 @ 12:43 pm EST
Geeklog Forums
Article paging in CVS
Status: offline
ByteEnable
Forum User
Full Member
Registered: 10/20/03
Posts: 138
Hi,
I've snarfed the article paging code from CVS. I've made some slight modifications and you can see an example here. Since adding this code to the core, the comment code is now jumping out at me. For example, currently comments are displayed on every page. I can change this very easily to only display comments on the first page of the article. My thoughts are that the comments should be displayed on the last page, instead of the first page or every page. I don't want user comments distracting from the article. However, to get comments to show up on the last page, requires moderate code changes to comments.php, as in a new functions, etc. Also it doesn't seem possible at the moment to have just a comment page displayed (without the article above it). On the commentbar you could add a link "View only comments" or something of that nature.
Ideal Commenting Wishlist
o Display comment page stand alone with options similar to static pages, i.e. blocks and so forth.
o On mulitple page articles, be able to establish which page comments are displayed on.
o Have the comment section expand into the third column on articles, like www.blender.org.
I actually have this running on my test server. It required changing the order of processing of COM_userComments and some very minor template mods.
Byte
I've snarfed the article paging code from CVS. I've made some slight modifications and you can see an example here. Since adding this code to the core, the comment code is now jumping out at me. For example, currently comments are displayed on every page. I can change this very easily to only display comments on the first page of the article. My thoughts are that the comments should be displayed on the last page, instead of the first page or every page. I don't want user comments distracting from the article. However, to get comments to show up on the last page, requires moderate code changes to comments.php, as in a new functions, etc. Also it doesn't seem possible at the moment to have just a comment page displayed (without the article above it). On the commentbar you could add a link "View only comments" or something of that nature.
Ideal Commenting Wishlist
o Display comment page stand alone with options similar to static pages, i.e. blocks and so forth.
o On mulitple page articles, be able to establish which page comments are displayed on.
o Have the comment section expand into the third column on articles, like www.blender.org.
I actually have this running on my test server. It required changing the order of processing of COM_userComments and some very minor template mods.
Byte
13
9
Quote
tokyoahead
Anonymous
Hi ByteEnable,
I have inserted the page_break code into the CVS. I will be looking into what you proposed.
I will get back to you as soon as I have a looked at the code closer again.
I have inserted the page_break code into the CVS. I will be looking into what you proposed.
I will get back to you as soon as I have a looked at the code closer again.
10
10
Quote
tokyoahead
Anonymous
I uploaded a new version to the CVS.
check out the new settings in config.php.
please give me some feedback on what you think.
check out the new settings in config.php.
please give me some feedback on what you think.
12
10
Quote
Status: offline
ByteEnable
Forum User
Full Member
Registered: 10/20/03
Posts: 138
Yeah I checked it out. Looks good from here. I have not tested the code yet, but I did look over it. The config options are a good thing . I will probably suck it in this weekend and let you know how it went! That was quick btw!
Byte
Byte
9
8
Quote
tokyoahead
Anonymous
please not that I update the lib_story.php yesterday night.
There was an error about the comments section again. somehow a complete commit of mine was lost in the process
There was an error about the comments section again. somehow a complete commit of mine was lost in the process
12
12
Quote
All times are EST. The time is now 12:43 pm.
- Normal Topic
- Sticky Topic
- Locked Topic
- New Post
- Sticky Topic W/ New Post
- Locked Topic W/ New Post
- View Anonymous Posts
- Able to post
- Filtered HTML Allowed
- Censored Content