Welcome to Geeklog, Anonymous Saturday, December 21 2024 @ 11:07 am EST

Geeklog Forums

Geeklog thinks ATOM1.0 as ATOM0.3


Status: offline

mystral-kk

Site Admin
Admin
Registered: 03/19/06
Posts: 100
Location:Japan
When I extended FeedParserFactory class (parserfactory.class.php) and read feeds in ATOM1.0, Geeklog-1.4.1 doesn't return the date of articles. I think I found a bug in parserfactory.class.php. The lines 235-241 are like this:
Text Formatted Code

          if( array_key_exists('VERSION', $attributes) )
          {
            $this->readerName = 'Atom03';
          } else {
            $this->readerName = 'Atom10';
          }
          $this->readerName = 'Atom03';
 
However, the last line 241 should be removed. Otherwise all ATOM feeds will be regarded as 'Atom03'. In addition, in atom.feed.class.php, at the lines 227, 229, 447 and 449, "currentItem['date']" should be "_currentItem['date'] (with an underscore)".
-- mystral-kk, "Every cloud has a silver lining."
 Quote

Status: offline

THEMike

Forum User
Moderator
Registered: 07/25/03
Posts: 141
Location:Sheffield, UK
Thanks for finding that, fix committed to CVS.
 Quote

All times are EST. The time is now 11:07 am.

  • Normal Topic
  • Sticky Topic
  • Locked Topic
  • New Post
  • Sticky Topic W/ New Post
  • Locked Topic W/ New Post
  •  View Anonymous Posts
  •  Able to post
  •  Filtered HTML Allowed
  •  Censored Content