Geeklog Forums

Hello, all.

You know we can replace 'COM_siteHeader'/'COM_siteFooter' function with 'Theme_siteHeader'/'Theme_siteFooter' in functions.php, but cannot replace other 'COM_***' function in this way.
This is the the hack emulates Overriding/Inheriting 'COM_***' function in '/public_html/lib-common.php'.

I really wish Geeklog would merge this hack by the default because It enables us to extend the functions and expand the use of Geeklog, though I think it should be discussed.
If all would feel it's good, I should be happy

The advantage of this hack:
1.Emulating Overriding/Inheriting 'COM_***' function.
2.Enabling us to extend Geeklog's functions without hacking the core-script, with minimum hack.
3.Protecting 'COM/Theme_***' function from infinite loops.
etc.

How to hack:
1. Modify/Insert some code in the head of each 'COM_***' function in '/public_html/lib-common.php' like an example.

This is an example of 'COM_getBlockTemplate' function.


Usage(an example):
After this hack, we can replace 'COM_getBlockTemplate' with 'Theme_getBlockTemplate' in functions.php like present 'COM_siteHeader/Footer' function.
In addition, we can call 'COM_getBlockTemplate' function from 'Theme_getBlockTemplate' function.

An example by kino who is a member of Geeklog Japanese.


Thank you for reading.

-----------
Phize

Isn't the array that COM_getBlockTemplate uses to find the template files is already in the theme's functions.php file? The example from kino could just be outside a function in the functions.php file. There's no reason to update the BLOCK_TEMPLATE structure every time there a call to COM_getBlockTemplate. In fact doing so slows your system down since the SQL will return the same data. On my test system I added:

echo "Call to COM_getBlockTemplate(blockname=$blockname, which=$which)<br>";

to COM_getBlockTemplate and it seems it was called 12 times. That's twelve times you would be hitting the blocks table per website hit and of course that's silly since the details in the blocks table will not change during a single website hit.

If you really need this kind of functionality, you ask them to do the function correctly.
The kino's example should be:

And of course, as I said, this could also be:

But I digress. Using debug tracing to allow functions to call out to other functions and back is much more safely done using controlled return codes. An empty return from THEME_getBlockTemplate is also much easier to understand for new readers of the code.

hello.
I'm kino.

It is because a theme wasn't applied when making a plug-in effective with the management screen that we needed this code.

I attempted to change as follows because there was wasteful access as the pointing-out.

I still don't understand. The loading of BLOCK_TEMPLATE happens in functions.php of the professional theme outside of any functions. Once it is loaded, why load it again? You don't need to put it into a function. Just load it in the theme's functions.php like professional does.

Unless you are coding specific blocks versus specific users there's no need to override COM_getBlockTemplate. And as I posted above, the proper way to modify COM_getBlockTemplate is to look for THEME_getBlockTemplate and call it. If it returns a string return it, otherwise perform the rest of the code in COM_getBlockTemplate. No need to jump through hoops with debug_backtrace.

In other words, this design style is more in keeping with Geeklog
1) Call a standard call
2) If an override function exists
2a) Call it if it return NULL or FALSE go to step 3
2b) Otherwise pass return to caller. Stop.
3) Continue with standard processing
4) Return result to caller.

If the override function is called it:
1) Checks to see if it should override
1a) If it should not override, return FALSE or NULL to the original function. Stop.
1b) Process the inputs
2) Return valid result to main function.

There's no reason for the override function to call the original function.