Geeklog Forums

We Geeklog Japanese group changed theme name 'ProfessionsCSS' to 'professional_css'.

And I added style to admin/config/configuration.thtml, because left side bloack is too narrow.
http://code.google.com/p/geeklog-jp/source/browse/trunk/geeklog-jp/public_html/layout/professional_css/admin/config/configuration.thtml
left: 25% right:75%

and I deleted font-family style on tool tips..
http://code.google.com/p/geeklog-jp/source/browse/trunk/geeklog-jp/public_html/layout/professional_css/jquery_ui/jquery-ui.css

How about this changes.

Thanks.

---

Geeklog Japan https://www.geeklog.jp

Just pasting this here from our email conversation, as I think that I have a valid point here.



Rouslan

Hey Ivy,



For any jQuery CSS stuff you should probably update the jquery.ui.geeklog.css file. It just makes updating jQuery easier if I do not have to worry about copying over any changes in those files.



Your updated column sizes look better. The problem of a really long word that Roccivic mentioned can happen but it could potenially happen anyways even with out the widths specified (ie both columns have a really long word) so for myself I am not to worried about that.

As far as inline styles are concerned I know that they are a no no, but I am guilty of this as well. I think since we have several people working on themes we should develop some sort of html/css standard (at least a basic one) like we do for PHP coding.

For example here are a few questions that I have:

1) Inline styles are usually frowned upon but is it "okay" if it is just one or two items (like setting the text align for a table colum) or should we create a class for that

2) How should are css class definitions look? How about spacing? (ie vertical-align:top; or vertical-align: top

3) How should we name classes?

4) etc...

Answering these types of questions will make things a bit easier. As a reference Drupal has started a CSS coding standard http://drupal.org/node/302199

Tom

---

One of the Geeklog Core Developers.

Hard coding "left: 25% right:75% " is better, and css style coding is best I think, too.

---

Geeklog Japan https://www.geeklog.jp

Hardcoding text-aligns is especially a bad idea, as I think it will compromise RTL support (we have exactly this problem in the forum plugin ATM). Though I'd have no problems with inline delarations for, say, font-weight.


It looks good, let's just steal it, like we did with the PEAR standard
How is it that we handle RTL anyway? We don't really have conditional CSS file loading mechanism like in Drupal, right?

Nope, nothing fancy like this. All you have to go by is the $LANG_DIRECTION variable. I think in some places we set that as a template variable so that you can then use it in CSS class names.

bye, Dirk

Templates of configuration use table layout.
But I don't like table layout.
Only configuration use table layout in professional_css.

---

Geeklog Japan https://www.geeklog.jp

Yeah, that was something I was going to look into at some point but never got around to it. Your more than welcome to submit a patch for it


In regards to the CSS coding standard, I will add it to the wiki using most of what Drupal has and post a link here for others to contribute.

---

One of the Geeklog Core Developers.